-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ArchGetFileName
for windows to return full path
#3361
base: dev
Are you sure you want to change the base?
Improve ArchGetFileName
for windows to return full path
#3361
Conversation
@nvmkuruc @nvidia-jomiller for vis. |
// Open a file, check that the file path from FILE* handle is matched. | ||
ARCH_AXIOM((firstFile = ArchOpenFile(firstName.c_str(), "rb")) != NULL); | ||
std::string filePath = ArchGetFileName(firstFile); | ||
ARCH_AXIOM(_DosDevicePathFilter(filePath) == _DosDevicePathFilter(firstName)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would comparing ArchAbsPath
be sufficient instead of _DosDevicePathFilter
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work to me.
Filed as internal issue #USD-10302 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change(s)
In a fix to improve Alembic plugin to read assets with ArResolver to support other sources except local files (#3302), it provides 4 options and 3 of them are using istream interfaces which has flaws to support layered ABC files. The only solution needs to fix
ArchGetFileName
to return full path fromFILE*
.Fixes Issue(s)